Problem 455 - Uninitialized variable in G4InelasticInteraction causes un-reproducible results
Summary: Uninitialized variable in G4InelasticInteraction causes un-reproducible results
Status: CLOSED FIXED
Alias: None
Product: Geant4
Classification: Unclassified
Component: processes/hadronic/management (show other problems)
Version: other
Hardware: All All
: P2 major
Assignee: Hans-Peter.Wellisch
URL:
Depends on:
Blocks:
 
Reported: 2003-02-11 18:14 CET by dennis.herbert.wright
Modified: 2003-03-13 02:13 CET (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this problem.
Description dennis.herbert.wright 2003-02-11 18:14:33 CET 
The variable "cache" in G4InelasticInteraction is in some cases not initialized
before it is used.  For example in the method
G4InelasticInteraction::CalculateMomenta, cache is not initialized before use
if the reaction is quasi-elastic.  For the case of GenerateXandPt and TwoCluster,
the method Rotate is called which initializes cache.  Hence for quasi-elastic
events we get unpredictable behavior.  For the time being, I initialize cache
to 0.0 in the constructor of G4InelasticInteraction.  This makes things
reproducible again.
Comment 1 Hans-Peter.Wellisch 2003-02-12 02:52:59 CET 
Hi Dennis,

   thank you for reporting this!

Many greetings,

Hans-Peter.
Comment 2 Hans-Peter.Wellisch 2003-02-12 03:02:59 CET 
Hi Dennis,

  a fix was submitted for system testing.

Many greetings,

Hans-Peter.
Comment 3 Hans-Peter.Wellisch 2003-03-13 02:13:59 CET 
As it turns out, the first fix was not sufficient.
A set of fixes went into patch-1 of 5.0.