Problem 377 - please check this.
Summary: please check this.
Status: CLOSED WORKSFORME
Alias: None
Product: Geant4
Classification: Unclassified
Component: processes/hadronic/models (show other problems)
Version: 4.0
Hardware: All All
: P5 trivial
Assignee: Hans-Peter.Wellisch
URL:
Depends on:
Blocks:
 
Reported: 2002-06-07 10:51 CEST by Hans-Peter.Wellisch
Modified: 2002-09-06 02:26 CEST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this problem.
Description Hans-Peter.Wellisch 2002-06-07 10:51:25 CEST 
Hi,

  can you please check the following lines of code?

src/G4RIsotopeTable.cc ; 203
src/G4RadioactiveDecay.cc ; 671

there are '-' signs that may not need to be there.

Many greetings,

Hans-Peter.
Comment 1 Hans-Peter.Wellisch 2002-06-09 10:16:59 CEST 
Hi Fan, can you please have a look?

Many greetings,

Hans-Peter.
Comment 2 Hans-Peter.Wellisch 2002-06-17 04:14:59 CEST 
no response from Fan, yet, and no way to enter his E-mail address into the error
reporting system....
Comment 3 Fan.Lei 2002-07-25 09:36:59 CEST 
Hi Hans-Peter,

I have done some tests and it seems the "-" are indeed needed there, remove
them the code will not work!

I think the statement
    while (!found && -DecaySchemeFile.getline(inputChars, 80).eof() != EOF)
is equivalent to
    while (!found && !DecaySchemeFile.getline(inputChars, 80).eof() )

Thus this is not a bug, but obviously the second statement is a much better
code. I will make the changes for funture releases.

Regards.

Fan
Comment 4 Hans-Peter.Wellisch 2002-07-26 02:01:59 CEST 
thank you for checking.

Many greetings,

Hans-Peter.
Comment 5 Hans-Peter.Wellisch 2002-08-08 07:23:59 CEST 
this is correct as is...