Problem 2511 - G4RadioactiveDecay::SetICM() is inefficient
Summary: G4RadioactiveDecay::SetICM() is inefficient
Status: RESOLVED FIXED
Alias: None
Product: Geant4
Classification: Unclassified
Component: processes/hadronic/models/radioactive_decay (show other problems)
Version: other
Hardware: All All
: P4 minor
Assignee: dennis.herbert.wright
URL:
Depends on:
Blocks:
 
Reported: 2022-09-24 16:58 CEST by michel.maire
Modified: 2022-10-24 18:35 CEST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this problem.
Description michel.maire 2022-09-24 16:58:23 CEST 
Silently, the function G4RadioactiveDecay::SetICM( ) does nothing.
We may expect a warning that this function is obsolete.
And gives an alternative, if any ...
Comment 1 dennis.herbert.wright 2022-10-13 22:11:20 CEST 
The PhotonEvaporation code now handles the ICM flag; ICM is always turned on in radioactive decay and so the command invoking G4RadioactiveDecay::SetICM() has no effect.  I will add a deprecation message to this method.
Comment 2 dennis.herbert.wright 2022-10-13 22:26:59 CEST 
I see that an inactivity message is already there in the messenger class:

"Command not active; kept for backward compatibility."
"Internal conversion is always turned on."

Does this not appear when you invoke it?
Comment 3 michel.maire 2022-10-14 13:18:23 CEST 
1- the message appear in the description of the UI commands (help), not when you issue the command itself.
2- in rdecay01, I used directly the statement radioactiveDecay->SetICM(false);
 this call is silent.
Comment 4 dennis.herbert.wright 2022-10-24 18:35:16 CEST 
SetICM() now removed from G4RadioactiveDecay and messenger.