Problem 2384 - G4Version.hh change issue
Summary: G4Version.hh change issue
Status: RESOLVED FIXED
Alias: None
Product: Geant4
Classification: Unclassified
Component: global (show other problems)
Version: 10.7
Hardware: All All
: P4 trivial
Assignee: Gabriele Cosmo
URL:
Depends on:
Blocks:
 
Reported: 2021-06-09 17:08 CEST by Matthias Plum
Modified: 2021-06-10 11:25 CEST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this problem.
Description Matthias Plum 2021-06-09 17:08:28 CEST 
Dear developer,

In the recent change of the G4Version.hh the #ifndef G4VERSION_NUMBER was changed.
in 10.71 it is:
#ifndef G4VERSION_NUMBER
# define G4VERSION_NUMBER 1071
#endif


whereas it was before:
#ifndef G4VERSION_NUMBER
#define G4VERSION_NUMBER 1063
#endif

The additional space in the '# define' is causing a small cmake problem in our software and I wasn't able to fix it on our end to keep it backward compatible.

Is this change between the geant4 version really necessary? Or was it maybe introduced by accident? Thank you!
Comment 1 Gabriele Cosmo 2021-06-09 17:35:35 CEST 
This was likely due to unwanted code formatting.
Will be fixed in next patch. Thanks for reporting.
Comment 2 Gabriele Cosmo 2021-06-10 11:25:28 CEST 
btw, the additional space introduced should *not* invalidate the macro definition anyhow... you better fix your configuration if that creates a problem for you, as we cannot guarantee that in other places in the code formatting of macros definitions result in similar patterns!