1981 – There are serious problems reported by valgrind

Problem 1981 - There are serious problems reported by valgrind

Summary: There are serious problems reported by valgrind

Status:	RESOLVED FIXED

Alias:	None

Product:	Examples/Advanced
Classification:	Unclassified
Component:	gammaray_telescope (show other problems)
Version:	other
Hardware:	All All

Importance:	P4 normal
Assignee:	longof

URL:

Depends on:
Blocks:

Reported:	2017-06-19 16:41 CEST by Vladimir.Ivantchenko
Modified:	2018-05-18 09:01 CEST (History)
CC List:	1 user (show)

See Also:

Attachments
valgrind output with all warnings. (2.18 MB, text/plain) 2017-06-19 16:41 CEST, Vladimir.Ivantchenko	Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this problem.

Description Vladimir.Ivantchenko 2017-06-19 16:41:13 CEST

Created attachment 461 [details]
valgrind output with all warnings.

Hello,

using geant4-10-04-beta_cand00 a very long list of warnings was obtained with standard macro for this example. This is a serious problem because this test crash with new development of correlated gamma emission in radioactive decay.

Difficult to say but my first suspect is the detector construction class to be reviewed.


Vladimir

Comment 1 francesco.longo 2017-07-12 12:32:55 CEST

I have seen the reported bug and I will work on it in the future weeks. From the warnings many of them are not related to the example classes. I will investigate the reported crashes with the new tags.

Comment 2 Gabriele Cosmo 2018-02-09 08:50:36 CET

Please, have a look at the attached Valgrind log. There're many memory errors reported and they relates to the example!
Those that comes from geometry kernel classes are likely a consequence of these, as non-initialised variables are passed around..

==1911== Conditional jump or move depends on uninitialised value(s)
==1911==    at 0x7894D2: GammaRayTelPrimaryGeneratorAction::GeneratePrimaries(G4Event*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB98728: G4WorkerRunManager::GenerateEvent(int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB96C09: G4WorkerRunManager::DoEventLoop(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB89852: G4RunManager::BeamOn(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB9B874: G4WorkerRunManager::DoWork() (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xBA3601: G4MTRunManagerKernel::StartThread(void*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0x5E35AA0: start_thread (in /lib64/libpthread-2.12.so)
==1911==    by 0x6133BCC: clone (in /lib64/libc-2.12.so)
==1911== 
==1911== Conditional jump or move depends on uninitialised value(s)
==1911==    at 0x7894F5: GammaRayTelPrimaryGeneratorAction::GeneratePrimaries(G4Event*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB98728: G4WorkerRunManager::GenerateEvent(int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB96C09: G4WorkerRunManager::DoEventLoop(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB89852: G4RunManager::BeamOn(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB9B874: G4WorkerRunManager::DoWork() (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xBA3601: G4MTRunManagerKernel::StartThread(void*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0x5E35AA0: start_thread (in /lib64/libpthread-2.12.so)
==1911==    by 0x6133BCC: clone (in /lib64/libc-2.12.so)
==1911== 
==1911== Conditional jump or move depends on uninitialised value(s)
==1911==    at 0x789635: GammaRayTelPrimaryGeneratorAction::GeneratePrimaries(G4Event*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB98728: G4WorkerRunManager::GenerateEvent(int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB96C09: G4WorkerRunManager::DoEventLoop(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB89852: G4RunManager::BeamOn(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB9B874: G4WorkerRunManager::DoWork() (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xBA3601: G4MTRunManagerKernel::StartThread(void*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0x5E35AA0: start_thread (in /lib64/libpthread-2.12.so)
==1911==    by 0x6133BCC: clone (in /lib64/libc-2.12.so)
==1911== 
==1911== Conditional jump or move depends on uninitialised value(s)
==1911==    at 0x599D687: __ieee754_atan2 (in /lib64/libm-2.12.so)
==1911==    by 0x59B8984: atan2 (in /lib64/libm-2.12.so)
==1911==    by 0x789D67: GammaRayTelPrimaryGeneratorAction::GeneratePrimaries(G4Event*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB98728: G4WorkerRunManager::GenerateEvent(int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB96C09: G4WorkerRunManager::DoEventLoop(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB89852: G4RunManager::BeamOn(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB9B874: G4WorkerRunManager::DoWork() (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xBA3601: G4MTRunManagerKernel::StartThread(void*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0x5E35AA0: start_thread (in /lib64/libpthread-2.12.so)
==1911==    by 0x6133BCC: clone (in /lib64/libc-2.12.so)
==1911== 
==1911== Conditional jump or move depends on uninitialised value(s)
==1911==    at 0x599D6AD: __ieee754_atan2 (in /lib64/libm-2.12.so)
==1911==    by 0x59B8984: atan2 (in /lib64/libm-2.12.so)
==1911==    by 0x789D67: GammaRayTelPrimaryGeneratorAction::GeneratePrimaries(G4Event*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB98728: G4WorkerRunManager::GenerateEvent(int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB96C09: G4WorkerRunManager::DoEventLoop(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB89852: G4RunManager::BeamOn(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB9B874: G4WorkerRunManager::DoWork() (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xBA3601: G4MTRunManagerKernel::StartThread(void*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0x5E35AA0: start_thread (in /lib64/libpthread-2.12.so)
==1911==    by 0x6133BCC: clone (in /lib64/libc-2.12.so)
==1911== 
==1911== Conditional jump or move depends on uninitialised value(s)
==1911==    at 0x599D6B5: __ieee754_atan2 (in /lib64/libm-2.12.so)
==1911==    by 0x59B8984: atan2 (in /lib64/libm-2.12.so)
==1911==    by 0x789D67: GammaRayTelPrimaryGeneratorAction::GeneratePrimaries(G4Event*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB98728: G4WorkerRunManager::GenerateEvent(int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB96C09: G4WorkerRunManager::DoEventLoop(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB89852: G4RunManager::BeamOn(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB9B874: G4WorkerRunManager::DoWork() (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xBA3601: G4MTRunManagerKernel::StartThread(void*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0x5E35AA0: start_thread (in /lib64/libpthread-2.12.so)
==1911==    by 0x6133BCC: clone (in /lib64/libc-2.12.so)
==1911== 
==1911== Conditional jump or move depends on uninitialised value(s)
==1911==    at 0x599D6F2: __ieee754_atan2 (in /lib64/libm-2.12.so)
==1911==    by 0x59B8984: atan2 (in /lib64/libm-2.12.so)
==1911==    by 0x789D67: GammaRayTelPrimaryGeneratorAction::GeneratePrimaries(G4Event*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB98728: G4WorkerRunManager::GenerateEvent(int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB96C09: G4WorkerRunManager::DoEventLoop(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB89852: G4RunManager::BeamOn(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB9B874: G4WorkerRunManager::DoWork() (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xBA3601: G4MTRunManagerKernel::StartThread(void*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0x5E35AA0: start_thread (in /lib64/libpthread-2.12.so)
==1911==    by 0x6133BCC: clone (in /lib64/libc-2.12.so)
==1911== 
==1911== Conditional jump or move depends on uninitialised value(s)
==1911==    at 0x599D6F6: __ieee754_atan2 (in /lib64/libm-2.12.so)
==1911==    by 0x59B8984: atan2 (in /lib64/libm-2.12.so)
==1911==    by 0x789D67: GammaRayTelPrimaryGeneratorAction::GeneratePrimaries(G4Event*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB98728: G4WorkerRunManager::GenerateEvent(int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB96C09: G4WorkerRunManager::DoEventLoop(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB89852: G4RunManager::BeamOn(int, char const*, int) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xB9B874: G4WorkerRunManager::DoWork() (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0xBA3601: G4MTRunManagerKernel::StartThread(void*) (in /afs/cern.ch/user/v/vnivanch/cwork/tests-build/gammaray_telescope/GammaRayTel)
==1911==    by 0x5E35AA0: start_thread (in /lib64/libpthread-2.12.so)
==1911==    by 0x6133BCC: clone (in /lib64/libc-2.12.so)

Comment 3 longof 2018-03-07 14:23:34 CET

Dear all, I started to work on the problem and I have some idea on how to solve it. I would provide a possible solution in a two-three weeks time scale. 
Franz

Comment 4 longof 2018-05-18 09:01:08 CEST

The warnings showed by valgrind have been addressed and solved.