1907 – G4ParticleHPFinalState::adjust_final_state() creates wrong secondary

Problem 1907 - G4ParticleHPFinalState::adjust_final_state() creates wrong secondary

Summary: G4ParticleHPFinalState::adjust_final_state() creates wrong secondary

Status:	RESOLVED FIXED

Alias:	None

Product:	Geant4
Classification:	Unclassified
Component:	processes/hadronic/models/neutron_hp (show other problems)
Version:	10.2
Hardware:	All All

Importance:	P4 trivial
Assignee:	dennis.herbert.wright

URL:

Depends on:
Blocks:

Reported:	2016-11-09 23:47 CET by Artem Zontikov
Modified:	2019-04-13 02:21 CEST (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this problem.

Description Artem Zontikov 2016-11-09 23:47:35 CET

The wrong secondary particle could be created here

http://www-geant4.kek.jp/lxr/source/processes/hadronic/models/particle_hp/src/G4ParticleHPFinalState.cc#L122

since theProjectile is not necessarily a neutron.


Also, these if-blocks

http://www-geant4.kek.jp/lxr/source/processes/hadronic/models/particle_hp/src/G4ParticleHPFinalState.cc#L76

http://www-geant4.kek.jp/lxr/source/processes/hadronic/models/particle_hp/src/G4ParticleHPFinalState.cc#L146

do not check if theProjectile is He3.

Comment 1 tkoi 2016-12-12 23:20:49 CET

The method was originally designed for neutron projectile. For other projectiles, we recommend to set “G4PARTICLEHP_DO_NOT_ADJUST_FINAL_STATE” environment variable and under the setting, the method never called. We have not yet decided how we treat this problem.

Comment 2 dennis.herbert.wright 2019-04-13 02:21:47 CEST

This problem appears to have been fixed in Geant4 10.4