Problem 1840 - Adding MT numbers to G4Step and G4ParticleHP
Summary: Adding MT numbers to G4Step and G4ParticleHP
Status: RESOLVED MOVED
Alias: None
Product: Geant4
Classification: Unclassified
Component: processes/hadronic/models/neutron_hp (show other problems)
Version: 10.2
Hardware: All All
: P5 enhancement
Assignee: dennis.herbert.wright
URL:
Depends on:
Blocks:
 
Reported: 2016-03-09 19:56 CET by Artem Zontikov
Modified: 2019-07-22 19:49 CEST (History)
1 user (show)

See Also:


Attachments
Adding MT numbers (144.58 KB, application/acrobat)
2016-03-09 19:57 CET, Artem Zontikov
Details

Note You need to log in before you can comment on or make changes to this problem.
Description Artem Zontikov 2016-03-09 19:56:17 CET
Consider the next enhancement to G4ParticleHP (attached).
Comment 1 Artem Zontikov 2016-03-09 19:57:11 CET
Created attachment 391 [details]
Adding MT numbers
Comment 2 tkoi 2016-04-26 03:35:09 CEST
Thank you for proposing an interesting extension.
I am not sure this can be achieved in current structure of Geant4 and particleHP (neutronHP). I will investigate the possibility of this extension.
However the information should be added to G4Track  instead of G4Step as you  proposed.

Tatsumi
Comment 3 Artem Zontikov 2016-04-28 13:42:49 CEST
Before the submission I checked proposed changes with G4 version 10.2, it works.

The information was added to G4Step on the analogy with GetProcessDefinedStep() method.

There is no problem in adding the information to G4Track instead of G4Step - only one additional function call is required. But it will also require changes to be made for some other processes outside particle_hp directory (transportation, step limiters, etc.).
Comment 4 dennis.herbert.wright 2018-08-29 11:50:39 CEST
The proposed fix modifies a class (G4Step) which is used throughout Geant4 and not just hadronic physics.  Changing such a general class to accommodate a specific model violates Geant4 design principles.  The proposed fix will therefore not be implemented, but other means of retrieving the MT information will be considered.
Comment 5 Artem Zontikov 2019-01-28 18:04:58 CET
Understood. 
Then what if we replace the proposed "G4int fReactionNumber" in "G4Step" class with "G4Cache<G4int> ReactionNumber" in "G4ParticleHPManager" class? 
I guess it would not violate any principle or interfere with any model other than ParticleHP.
Comment 6 dennis.herbert.wright 2019-07-22 19:49:38 CEST
This also would probably not be allowed.  However, we are considering changing the Geant4 hadronic framework to allow MT numbers.  If approved, we will add this capability in a more ENDF-friendly way.  I will move this issue to hadronic development and close it here.