Problem 1710 - Needless matrix inversion in G4NeutronHPInelasticCompFS::two_body_reaction
Summary: Needless matrix inversion in G4NeutronHPInelasticCompFS::two_body_reaction
Status: RESOLVED FIXED
Alias: None
Product: Geant4
Classification: Unclassified
Component: processes/hadronic/models/neutron_hp (show other problems)
Version: 10.0
Hardware: All All
: P5 trivial
Assignee: tkoi
URL:
Depends on:
Blocks:
 
Reported: 2015-02-05 09:01 CET by Thomas Kittelmann
Modified: 2015-02-11 17:07 CET (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this problem.
Description Thomas Kittelmann 2015-02-05 09:01:45 CET 
Looking into G4NeutronHPInelasticCompFS::two_body_reaction for other reasons (an FPE was triggered there, but still not confirmed if the cause is my own), I noticed that it ends with the lines:

   p4 *= rot.inverse();
   residual->SetMomentum ( p4 );
   delete residual;

Since p4 and residual are both local objects, I assume the first two of the lines above cut be thrown away, saving a matrix inversion. This was 10.0.p03.
Comment 1 tkoi 2015-02-11 17:07:30 CET 
Thank you for reporting this problem.

It looks like that some testing purpose codes are left in release.
I delete the part and also other unused codes in the function.

Tatsumi