Problem 1675 - change of G4Scintillation variables to static from Geant4.9 to Geant9.10, afecting different process for different particles
Summary: change of G4Scintillation variables to static from Geant4.9 to Geant9.10, afe...
Status: RESOLVED FIXED
Alias: None
Product: Geant4
Classification: Unclassified
Component: processes/optical (show other problems)
Version: 10.0
Hardware: All All
: P5 trivial
Assignee: gum
URL:
Depends on:
Blocks:
 
Reported: 2014-09-07 06:13 CEST by Thiago Bezerra
Modified: 2014-11-18 21:42 CET (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this problem.
Description Thiago Bezerra 2014-09-07 06:13:58 CEST 
Hello,

I am not sure if this is the best place to report it, but I notice that from Geant4.9 to Geant4.10 the private variables of G4Scintillation class were changed to static.

However, this affects applications that needs different scintillation process for different particles, as explained in the third paragraph of Section 5.2.5.2. Generation of Photons in processes/electromagnetic/xrays - Scintillation, of the User's Guide for Application Developers. There, and also in the advanced example underground physics, is written that for the case a scintillator has a different ratio between the fast and slow components depending on the particle type, a scintillation process can be invoked for each particle and its excitation ratio set individually. This is not possible any more, since the variable is static. A call to SetScintillationExcitationRatio will change the value for all the process created.

I understand that the G4OpticalPhys also has such variable and could be used, but in this case, the User's Guide explanation should be changed, describing how to do it accordingly.

Thank you for your attention.
Regards,
Thiago
Comment 1 gum 2014-09-12 01:24:03 CEST 
Thanks Thiago,

I'll look into this ... I think to remember that the static assignment was part of the  migration to multi-threading.

Regards, Peter
Comment 2 Thiago Bezerra 2014-10-08 18:28:19 CEST 
(In reply to comment #1)
> Thanks Thiago,
> 
> I'll look into this ... I think to remember that the static assignment was part
> of the  migration to multi-threading.
> 
> Regards, Peter

Hi Peter,

Thanks for taking a look into it.
Any news regarding this issue?

regards
thiago
Comment 3 Andrea Dotti 2014-11-17 18:51:21 CET 
A set of tags to solve this problem has been prepared. The tags will be part of 10.1 version of Geant4. Note that due to the nature of the problem and the need to support MT, we had to re-design naming scheme of optical-UI commands.
The new commands have a new structure and unfortunately the change is not back-compatible (e.g. macro files using optical UI commands need an update).

The functionality of 9.6 described in this report has been restored. And the use-case described here is now working again.

Andrea
Comment 4 Thiago Bezerra 2014-11-18 13:15:15 CET 
(In reply to comment #3)
> A set of tags to solve this problem has been prepared. The tags will be part of
> 10.1 version of Geant4. Note that due to the nature of the problem and the need
> to support MT, we had to re-design naming scheme of optical-UI commands.
> The new commands have a new structure and unfortunately the change is not
> back-compatible (e.g. macro files using optical UI commands need an update).
> 
> The functionality of 9.6 described in this report has been restored. And the
> use-case described here is now working again.
> 
> Andrea



Thank you very much Andrea, for fixing it and let us know!

Best regards,
Thiago