Problem 1493 - G4VSolid::EstimateCubicVolume does not actually use epsilon parameter
Summary: G4VSolid::EstimateCubicVolume does not actually use epsilon parameter
Status: RESOLVED FIXED
Alias: None
Product: Geant4
Classification: Unclassified
Component: geometry/solids (show other problems)
Version: 9.6
Hardware: All All
: P5 trivial
Assignee: tatiana.nikitina
URL:
Depends on:
Blocks:
 
Reported: 2013-07-16 11:59 CEST by Thomas Kittelmann
Modified: 2013-07-29 09:54 CEST (History)
0 users

See Also:


Attachments
Fix in EstimateCubicVolume (20.63 KB, text/x-c++src)
2013-07-29 09:51 CEST, tatiana.nikitina
Details

Note You need to log in before you can comment on or make changes to this problem.
Description Thomas Kittelmann 2013-07-16 11:59:02 CEST
Looking at:

////////////////////////////////////////////////////////////////
//
// Calculate cubic volume based on Inside() method.
// Accuracy is limited by the second argument or the statistics
// expressed by the first argument.
// Implementation is courtesy of Vasiliki Despoina Mitsou,
// University of Athens.

G4double G4VSolid::EstimateCubicVolume(G4int nStat, G4double epsilon) const

One would expect the epsilon parameter to be used if one wants to guarantee the result with some given accuracy.

However, the parameter is unused, apart from one line without effect (apart from perhaps quell compiler warnings):

  if(epsilon > 0.01) epsilon = 0.01;

Cheers,
Thomas
Comment 1 tatiana.nikitina 2013-07-29 09:51:47 CEST
Created attachment 233 [details]
Fix in EstimateCubicVolume
Comment 2 tatiana.nikitina 2013-07-29 09:54:16 CEST
Dear Thomas,

Thank you for reporting this error.
This error is fixed and will be available in the next geant4 release.
You can use already file in attachments. 

Best Regards,
Tatiana Nikitina.