Problem 1028 - Infinite loop in G4CompetitiveFission::FissionCharge due to typo
Summary: Infinite loop in G4CompetitiveFission::FissionCharge due to typo
Status: RESOLVED FIXED
Alias: None
Product: Geant4
Classification: Unclassified
Component: processes/hadronic/models/de_excitation/fission (show other problems)
Version: 9.1
Hardware: All All
: P5 major
Assignee: dennis.herbert.wright
URL:
Depends on:
Blocks:
 
Reported: 2008-10-29 01:40 CET by marcus.h.mendenhall
Modified: 2008-11-27 16:56 CET (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this problem.
Description marcus.h.mendenhall 2008-10-29 01:40:03 CET 
We ran across infinite looping in G4CompetitiveFission::FissionCharge, and traced it to the following:

lines 342-344 currently are:
    if (Af >= 134.0) DeltaZ = -0.45;                    //                      134 <= Af
    else if (A <= (A-134.0)) DeltaZ = 0.45;             // Af <= (A-134) 
    else DeltaZ = -0.45*(Af-(A/2.0))/(134.0-(A/2.0));   //       (A-134) < Af < 134

but, as one can see from the logic and comment, line 343 should be:

    else if (Af <= (A-134.0)) DeltaZ = 0.45;             // Af <= (A-134) 

This results in crazy parameters in the test in the lines below this which are trying to generate a gaussian within specific bounds, based on the impossible parameters.
Comment 1 dennis.herbert.wright 2008-11-27 16:56:04 CET 
Bug fixed and included in 9.2 release.