Problem 854

We have traced an infinite loop problem to line 687 in G4RadioactiveDecay.cc.
The infinte loop occurs, for example, when DecaySchemeFile corresponds to
z81.a188. This bug is probably not related to bug 843, as the infinite loop does
not occur for z81.a194. Here is some test code that exposes the bug (replace the
path to the data file with the appropriate path for your system):

#include <iostream>
#include <fstream>

using namespace std;

int main()
{
  ifstream f("/usr/local/geant4/geant4.8.0/data/RadiativeDecay/z81.a188");
  if(!f) {
    cout << "no file" << endl;
    return 1;
  }
  char inputChars[80]={' '};
  while (-f.getline(inputChars, 80).eof() != EOF) {
    cout << inputChars << endl;
  }
  return 0;
}

The problem is with the test for EOF, as noted at
http://mathbits.com/MathBits/CompSci/Files/End.htm

As stated on this webpage, the recommended fix is to replace the test for EOF
with just a boolean test on getline(), i.e.

while(f.getline(inputChars, 80)) { ... }

This solves the infinite loop in the sample code here. We recommend the same
modification be made to line 687 in G4RadioactiveDecay.cc, so that it reads

  while (!complete && DecaySchemeFile.getline(inputChars, 80))

Thanks,
Jason Detwiler and Mike Marino