Problem 2122

Summary:	Clarify how to contribute to the Geant4 project
Product:	Bugzilla	Reporter:	Sergio Losilla <sergio.losilla>
Component:	general	Assignee:	Gabriele Cosmo <Gabriele.Cosmo>
Status:	RESOLVED FIXED
Severity:	minor	CC:	asai, Ben.Morgan, sergio.losilla
Priority:	P4
Version:	other
Hardware:	All
OS:	All

Description Sergio Losilla 2019-01-26 18:06:22 CET

I submitted a pull request on the github repo:
https://github.com/Geant4/geant4/pulls

There are several more, so I wonder if it is because no one has had time to have a look or it was the wrong place to submit those changes.

I notice that I am not the only person who is not sure about how to contribute (https://bugzilla-geant4.kek.jp/show_bug.cgi?id=2121). The CONTRIBUTING.md file directs to the list of contributors as of v10.5.0:

https://github.com/Geant4/geant4/blob/master/CONTRIBUTING.md

Adding instructions in there should send people to the right place to avoid people like me doing annoying things like sending emails directly to the maintainers :-)

Comment 1 Gabriele Cosmo 2019-01-31 09:05:08 CET

Hi Sergio, submitting a pull request in GitHub is perfectly fine and will be considered
in due time by a responsible (yours was opened just 2 weeks ago, doesn't look critical
and touches many files...).
Two of the PRs in GitHub have been already addressed (one, also Bugzilla ticket #2121)
as been evaluated as invalid and, if confirmed, will be eventually closed; another one
invalid as well as the code does not compile on our supported platforms...
In general, for bug reports, it is more convenient to use our Bugzilla bug tracking
system, where it is also possible to attach suggested patches.
Submitting PRs in GitHub is fine; though, the changes will not be integrated directly
in the released code but will have to be first evaluated in the current development
and then eventually appear in a new patch release (if it is a fix) or in the next
release.
We'll update the CONTRIBUTING document to explain this. Thanks.

Comment 2 Sergio Losilla 2019-01-31 12:01:49 CET

(In reply to Gabriele Cosmo from comment #1)

Hi Gabriele,

Thank you for your reply. Yes, of course I do not expect my proposals to be even accepted, even less to be reviewed immediately :-D I just wanted to be sure that I was not knocking on the wrong door.

Thanks for having a look at the CONTRIBUTING file.

Cheers,

Sergio

Comment 3 Gabriele Cosmo 2019-02-12 14:35:27 CET

CONTRIBUTING file now updated.