| Summary: | Faulty low energy photonuclear cross section lookup for deuteron | ||
|---|---|---|---|
| Product: | Geant4 | Reporter: | ed_bugs |
| Component: | processes/hadronic/cross_sections | Assignee: | dennis.herbert.wright |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P4 | ||
| Version: | 10.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugzilla-geant4.kek.jp/show_bug.cgi?id=2093 | ||
| Attachments: |
Illustration of correcting the xs lookup for deuterium only
Illustration of correcting the xs lookup for deuterium only |
||
|
Description
ed_bugs
2018-10-05 20:13:47 CEST
Created attachment 513 [details]
Illustration of correcting the xs lookup for deuterium only
Header file illustrating a correction to the xs lookup for deuterium only.
Created attachment 514 [details]
Illustration of correcting the xs lookup for deuterium only
Source file illustrating a correction to the xs lookup for deuterium only.
Your fix looks OK to me, but why did you place all instances of G4Log with std::log ? G4Log was specially designed to perform faster calculations than std::log. Presumably you're referring to the energy bounds relevant to the mid-energy (100ish MeV - 50 GeV) interpolation scheme --- the project in which this was discovered is built against version 10.00.p02, in which std::log was the original implementation. Looking at the latest release (10.03.p03), G4Log is used. Your fix was implemented. Thanks for reporting it. |