Problem 1710

Summary: Needless matrix inversion in G4NeutronHPInelasticCompFS::two_body_reaction
Product: Geant4 Reporter: Thomas Kittelmann <thomas.kittelmann>
Component: processes/hadronic/models/neutron_hpAssignee: tkoi
Status: RESOLVED FIXED    
Severity: trivial    
Priority: P5    
Version: 10.0   
Hardware: All   
OS: All   

Description Thomas Kittelmann 2015-02-05 09:01:45 CET 
Looking into G4NeutronHPInelasticCompFS::two_body_reaction for other reasons (an FPE was triggered there, but still not confirmed if the cause is my own), I noticed that it ends with the lines:

   p4 *= rot.inverse();
   residual->SetMomentum ( p4 );
   delete residual;

Since p4 and residual are both local objects, I assume the first two of the lines above cut be thrown away, saving a matrix inversion. This was 10.0.p03.
Comment 1 tkoi 2015-02-11 17:07:30 CET 
Thank you for reporting this problem.

It looks like that some testing purpose codes are left in release.
I delete the part and also other unused codes in the function.

Tatsumi