Problem 1684

When a user defined photon evaporation file is present in the destructor there is an attempt to delete G4String as part of the map used to store the filenames.

Unlike the other maps, the "second" component of theUserDataFiles is not a pointer.

Here is a proposed patch to fix this issue:

diff --git a/source/processes/hadronic/models/de_excitation/photon_evaporation/src/G4NuclearLevelStore.cc b/source/processes/hadronic/models/de_excitation/photon_evaporation/src/G4NuclearLevelStore.cc
index 21122ca..1bf2461 100644
--- a/source/processes/hadronic/models/de_excitation/photon_evaporation/src/G4NuclearLevelStore.cc
+++ b/source/processes/hadronic/models/de_excitation/photon_evaporation/src/G4NuclearLevelStore.cc
@@ -71,11 +71,13 @@ G4NuclearLevelStore::~G4NuclearLevelStore()
   MapForHEP::iterator j;
   for (j = managersForHEP.begin(); j != managersForHEP.end(); ++j)
     { delete j->second; }
-  if(userFiles) {
-    std::map<G4int, G4String>::iterator k;
-    for (k = theUserDataFiles.begin(); k != theUserDataFiles.end(); ++k)
-      { delete k->second; }
-  }
+
+  // G4String cannot be deleted since it is not pointer.  we can clear
+  // the map ourselves to be consistent but this should happen
+  // automatically.
+
+  // No need to check for Boolean userFiles
+  theUserDataFiles.clear();
 }